huge tps lag on world generation

[Biviho]

hi, i have noticed tps lag when it tries to generate little water lake with the mod's plant and stalactites, this is more noticable in large modpack, where it can cause server freeze. would it be possible to add option for the world generation? like the chance for a chunk to generate features, the number of tries per chunk, dimension, if to be generated at all?

also, plants and stalactite do only generate on worldgen or there is an update that check for water underground to spawn plants and stalactites based on the xp in the chunk?

[hohserg1]

hello can you export modpack in curselauncher and publish archive here or in pm? it will be helpful for profiling

[hohserg1]

also, plants and stalactite do only generate on worldgen or there is an update that check for water underground to spawn plants and stalactites based on the xp in the chunk?

only on worldgen

[Biviho]

hello can you export modpack in curselauncher and publish archive here or in pm? it will be helpful for profiling

I intend to make the pack public, but since is still early in development i have never looked out on how to publish it, will look into it later today!

also, plants and stalactite do only generate on worldgen or there is an update that check for water underground to spawn plants and stalactites based on the xp in the chunk?

only on worldgen

Oh ok...then this tps lag is a bit odd...it might be some interaction with other worldgen mod in the modpack or caused by one of the optimization...? I will try to exclude some mod after exporting the pack later today.

Btw, an option to disable worldgen so that a user can add it's own with mods like cofh world could be useful just in case

[hohserg1]

Also try to reproduce lag effect without Soulkeeper. Tell me if effect will vanish.

[Biviho]

Yup, already tested that when opened the issue:

--------------without soulkeeper------------ Going spectator mode underground and moving fast in one direction cause ticks to be around 120-140ms (around 5-8 tick per second) "stable". When i stop, after around 3 seconds, tps go back to arount 20. It's a big modpack but i have done what i could to optimize it, at least on my pc.

---------------------with soulkeeper---------------- Moving underground in spectator in one direction goes from around 120-140ms to 250ms after an occasional freeze of 3-5 seconds, usually after the freeze, an underground lake with soulkeeper features is generated and visible. Occasionally the server will just totally freeze, and sometime recover after a long time (>60 s), sometimes more (usually i kill the process at that point)

I will give you better details when i get to my pc.

[Biviho]

i might have found if not the mod that interact weirdly with soulkeeper, at least one of the mods: yung better caves.

i use it in my pack to generate long underwater caves and the tps lag is not when soulkeeper feature are generated, but when there is huge patch of water underground, and sometime there is also soulkeeper feature that get generated.

------tested it in my pack by removing yung and keeping soulkeeper, while tps lag spikes appear from time to time, going slowly does not cause server freeze anymore. ------testing it on a small pack with both soulkeeper and yung better caves cause both lagspikes and occasionally server freezes for around 15 seconds (less than in my pack, but my pack is huge, 315 mods). ------in a small modpack with only soulkeeper or only better caves there is no problem.

it looks like there is no limit to the number of water source block that get checked for soulkeeper patch to spawn, if that's the way soulkeeper feature are generated, does this make sense?

[hohserg1]

Perfect! I have some ideas how to generate plants more optimized. So I will try it with YUNG's Better Caves. Also, I see Better Caves have a several sub-mods. Which ones do you use?

[hohserg1]

Also, do you have cascading worldgen issue? I got it when added YUNG's Better Caves to modpack

[Server thread/WARN] [FML]: Soulkeeper loaded a new chunk [-9, -10] in dimension 0 (overworld) while populating chunk [-9, -9], causing cascading worldgen lag.
[Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

[Biviho]

i'm using yung better caves and yung better mineshaft, other yung mods are only on 1.14+

this are my configs (important for flooded caves) bettercaves-1_12_2.txt bettermineshafts-1_12_2.txt

i changed the extension to txt cause for some reason it didn't wanted me to upload it as zip, change it back to cfg, also, i will make a new post with a bunch of suggestions/ideas, if that can give you some inspiration

[Biviho]

Also, do you have cascading worldgen issue? I got it when added YUNG's Better Caves to modpack

[Server thread/WARN] [FML]: Soulkeeper loaded a new chunk [-9, -10] in dimension 0 (overworld) while populating chunk [-9, -9], causing cascading worldgen lag.
[Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

actually yes

[21:02:20] [Server thread/WARN] [FML]: Soulkeeper loaded a new chunk [-7, -48] in dimension 0 (overworld) while populating chunk [-6, -47], causing cascading worldgen lag.
[21:02:20] [Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.
[21:02:20] [Server thread/WARN] [FML]: Soulkeeper loaded a new chunk [-8, -48] in dimension 0 (overworld) while populating chunk [-7, -48], causing cascading worldgen lag.
[21:02:20] [Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.
[21:02:20] [Server thread/WARN] [FML]: Soulkeeper loaded a new chunk [-9, -49] in dimension 0 (overworld) while populating chunk [-8, -48], causing cascading worldgen lag.
[21:02:20] [Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

[hohserg1]

Soulkeeper-2.9.7-for-1.12.2.jar.zip Ok, try it, plz. Just rename extension to jar

[Biviho]

tested with and without soulkeeper and better caves, looks like it's working!

[hohserg1]

https://www.curseforge.com/minecraft/mc-mods/soulkeeper-2/files/3657950