search

hoijui / JavaOSC

OSC content format/"protocol" library for JVM languages
http://www.illposed.com/software/javaosc.html
BSD 3-Clause "New" or "Revised" License
156 stars 43 forks source link

Miss calculating types when 4 byte boundary aligns with a 1st string argument #14

Closed pcross616 closed 9 years ago

pcross616 commented 9 years ago

When the 4 byte boundary aligned with the types and the first argument was a string it would look at the string as additional types. We need to pad after the types if the % 4 == 0 so that we know that there are no more types.

hoijui commented 9 years ago

hey peter! :-) would it be ok for you if i pushed my own fix instead of yours? thanks a lot for your patches and the bug report inherently included with it. i really want to give you credit (an i do in the commit messages), but there is a simpler solution.

pcross616 commented 9 years ago

Sure don't care just wanted to make sure it was reported and an example fix.

Sent from my Windows Phone

From: hoijuimailto:notifications@github.com Sent: ‎10/‎12/‎2014 5:45 AM To: hoijui/JavaOSCmailto:JavaOSC@noreply.github.com Cc: Peter Crossleymailto:peterc@xley.com Subject: Re: [JavaOSC] Miss calculating types when 4 byte boundary aligns with a 1st string argument (#14)

hey peter! :-) would it be ok for you if i pushed my own fix instead of yours? thanks a lot for your patches and the bug report inherently included with it. i really want to give you credit (an i do in the commit messages), but there is a simpler solution.

— Reply to this email directly or view it on GitHubhttps://github.com/hoijui/JavaOSC/pull/14#issuecomment-58796150.

hoijui commented 9 years ago

cool! :-) it should be fixed with this commit: https://github.com/hoijui/JavaOSC/commit/c1c0f46aaad001a26f9b1a066e4b9e798c7c4289