Don't move to FourByteBoundary after reading blob when already on it

hoijui / JavaOSC

OSC content format/"protocol" library for JVM languages

http://www.illposed.com/software/javaosc.html

BSD 3-Clause "New" or "Revised" License

156 stars 43 forks source link

Don't move to FourByteBoundary after reading blob when already on it #27

Closed 7890 closed 7 years ago

7890 commented 7 years ago

in OSCByteArrayToJavaConverter.java: in private byte[] readBlob(final Input rawInput): moveToFourByteBoundry(rawInput);

-> if the blob ends on a 4-byte boundary, moveToFourByteBoundry() will move to +4 bytes. -> according to spec, after a blob, there are 0-3 pad bytes (never >3)

the superfluous bytes after a blob of size n*4 will confuse other OSC libraries.

greetings

hoijui commented 7 years ago

Thanks for pointing this out. :-) It is already fixed in develop in commit: cb021a83700c33164d874f820b22bd357ff8db86

I should really do a release soon!