search

hoijui / JavaOSC

OSC content format/"protocol" library for JVM languages
http://www.illposed.com/software/javaosc.html
BSD 3-Clause "New" or "Revised" License
157 stars 44 forks source link

OSCTimeStamp.toDate() not translated correctly #29

Closed nlowe closed 5 years ago

nlowe commented 7 years ago

It's not even close to my local time:

@OSCRoute("/go")
private void onGoNextCue(OSCTimeStamp time, OSCMessage message)
{
    Log.debug("Got GO NEXT CUE message at {}", time.toDate());
}
00:16:11.122 [DEBUG] soundclip.osc.OSCServer - Got GO NEXT CUE message at 2036-02-07T01:28:16.000-0500

Furthermore, it seems to be resolving to the same time each time. I'm not sure if this is an issue with the client (andrOSC), or the server (javaosc-core)

hoijui commented 7 years ago

TODO (for myself or any other dev. working on this): check time-stamp compatibility with liblo.

hoijui commented 7 years ago

.. jup @nlowe, you are fully right. JavaOSC currently uses very wrong code for time-tags. I don't know where it comes from, as it is similar but more complicated then the OSC(==NTP) format. I am currently fixing the code.

hoijui commented 5 years ago

The fix is on the develop branch: b2cc1a5f1a786408f34bcd7a1095de3442c41886