search

hoijui / JavaOSC

OSC content format/"protocol" library for JVM languages
http://www.illposed.com/software/javaosc.html
BSD 3-Clause "New" or "Revised" License
157 stars 44 forks source link

Make listening variable volatile for thread-safety #35

Closed danieldickison closed 6 years ago

danieldickison commented 6 years ago

This should make OSCPortIn thread-safe as long as startListening() and stopListening() are only called from a single thread. Takes care of part of issue #4.

hoijui commented 6 years ago

cool, thank you! :-) are you using this version of the library already? is it somewhat usable? thing is, i have no project using the library, so i only have the unit tests to judge. i also never made an API with NIO before, so i don;t know if it makes sense as it is right now, in practice. feel free to give comments/make changes there too, if you found practical problems. the API here changed a lot, and as it is not yet in master, we are quite free to change it even drastically. have a good day! :-)

hoijui commented 6 years ago

... ouhh you write CocoaOSC.. nice! :D seeing your photo here on github, i can tell you we look very similar! same hair style all around the head, and same glasses. .. i am probably 10 years older though. tell me if you need a place to crash in berlin. (... you somehow.. look trustworthy.. dunnu why)

danieldickison commented 6 years ago

Hi @hoijui! Thanks for the merge and the offer for a place to crash in Berlin :) I'm working on a personal side-project that uses Android tablets in a theater setting, and I'm experimenting with using OSC for controlling those tablets. I haven't gotten very far yet in that, but I will let you know how well JavaOSC works for this. It definitely looks promising so far. It would be great if I can get this to work cross-platform, so I might see if I can get this to transpile for iOS using j2objc though that's definitely a "later" goal.

hoijui commented 6 years ago

niiiice! :-) good luck with that.