Closed bertysentry closed 1 year ago
Updated to remove conflicts
I hope to get this reviewed next week, I'm just looking to finish up a small re-factor with the compiler first.
This might be annoying but could you perhaps change the PR so only the actual changes are recorded and not all the tab / spaces changes? (I believe the original code uses tabs and not spaces)
Hi @eyalroth
I'm very sorry, I just realized how much AwkCompilerImpl.java is screwed up. I don't understand why Github is showing it this way. Even the import ...
lines (which don't have spaces or tabs indentation) are marked as different! This is weird...
Besides, I'm more of a tab guy than a space guy... ;-)
I edited everything in Eclipse, which doesn't change spaces and tabs.
Anyway, I actually had no significant changes in AwkCompilerImpl.java.
Just:
Class<?>
than just Class
and similar issues)return cg.getJavaClass().getBytes()
at the end of the compile(AwkTuples)
method, so the caller can do whatever he wants with the bytecode (including loading it directly, without going through a .JAR file)None of this is really important and can therefore be safely discarded :-)
(edited after realizing my mistake with AwkCompilerImpl.java)
Bertrand,
sorry to use this email address but I don't have a better one.
I haven't wanted to write this so I have procrastinated for a long time. My heart was in the right place but I've been sick for months. Sometimes it's been hard to simply keep up with the activities of daily life. As much as I'd like to, I simply don't have the cycles to maintain the jawk project. Besides my problems, I think you would be the better maintainer since you have put so much into it.
My sincerest apologies, Constantine Rasmussen
On Wed, Jan 31, 2018, 9:47 AM Bertrand Martin notifications@github.com wrote:
This may conflict with other Pull Requests. If you merge other Pull Request before, I'll have to rebase, but it's okay ;-)
You can view, comment on, or merge this pull request online at:
https://github.com/hoijui/Jawk/pull/12 Commit Summary
- Improved .gitignore
- Added support for arbitrary PrintStream output (instead of System.out)
File Changes
- M .gitignore https://github.com/hoijui/Jawk/pull/12/files#diff-0 (7)
- M src/main/java/org/jawk/Awk.java https://github.com/hoijui/Jawk/pull/12/files#diff-1 (8)
- M src/main/java/org/jawk/Main.java https://github.com/hoijui/Jawk/pull/12/files#diff-2 (2)
- M src/main/java/org/jawk/backend/AVM.java https://github.com/hoijui/Jawk/pull/12/files#diff-3 (14)
- M src/main/java/org/jawk/backend/AwkCompiler.java https://github.com/hoijui/Jawk/pull/12/files#diff-4 (2)
- M src/main/java/org/jawk/backend/AwkCompilerImpl.java https://github.com/hoijui/Jawk/pull/12/files#diff-5 (144)
- M src/main/java/org/jawk/ext/CoreExtension.java https://github.com/hoijui/Jawk/pull/12/files#diff-6 (7)
- M src/main/java/org/jawk/intermediate/AwkTuples.java https://github.com/hoijui/Jawk/pull/12/files#diff-7 (49)
- M src/main/java/org/jawk/jrt/JRT.java https://github.com/hoijui/Jawk/pull/12/files#diff-8 (51)
- M src/main/java/org/jawk/jrt/VariableManager.java https://github.com/hoijui/Jawk/pull/12/files#diff-9 (1)
- M src/main/java/org/jawk/util/AwkParameters.java https://github.com/hoijui/Jawk/pull/12/files#diff-10 (5)
- M src/main/java/org/jawk/util/AwkSettings.java https://github.com/hoijui/Jawk/pull/12/files#diff-11 (27)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hoijui/Jawk/pull/12, or mute the thread https://github.com/notifications/unsubscribe-auth/ADAU9AqP6dm1yeeOL9IFZrqRCB9YJv6nks5tQH0BgaJpZM4R0Fcd .
Hi @cdrasmussen
I'm very sorry to hear about your health problems. I hope you'll get better soon!
I'd be happy to handle the maintenance of Jawk. As he was involved in Jawk maintenance too, maybe @eyalroth would like to handle that. @eyalroth ?
Thanks, -- Bertrand
i am a bit confused.. eyalroth is already the maintainer since some months now. if someone is unhappy for not getting commits into the repo due to lazy or too restrictive maintainer(s) (what aeh.. whom you all looking at?!!), ask for maintainer permissions. :-) to me he seems like eyalroth is doing a very good job at the moment.
This may conflict with other Pull Requests. If you merge other Pull Request before, I'll have to rebase, but it's okay ;-)