hoishing / cell-navigation

cell-navigation plugin for Atom text editor, companion of Hydrogen / Jupytext
MIT License
5 stars 4 forks source link

Uncaught TypeError: Cannot read property 'buffer' of undefined #3

Open ilya-ux opened 4 years ago

ilya-ux commented 4 years ago

[Enter steps to reproduce:]

  1. shift alt-cmd-k

Atom: 1.43.0 x64 Electron: 4.2.7 OS: Mac OS X 10.15.4 Thrown From: cell-navigation package 0.1.0

Stack Trace

Uncaught TypeError: Cannot read property 'buffer' of undefined

At /Users/ilyabenjamin/.atom/packages/cell-navigation/lib/utils.coffee:17

TypeError: Cannot read property 'buffer' of undefined
    at Object.cellRange (/packages/cell-navigation/lib/utils.coffee:17:24)
    at Object.moveCellUp (/packages/cell-navigation/lib/main.coffee:57:18)
    at /packages/cell-navigation/lib/main.coffee:13:43)
    at CommandRegistry.handleCommandEvent (/private/var/folders/ph/hb9gwd4j1vn7b6hnsbs84d6w0000gn/T/AppTranslocation/45A34DF2-7977-40F4-9E3D-731AC719BB3F/d/Atom.app/Contents/Resources/app/static/<embedded>:11:349290)
    at KeymapManager.dispatchCommandEvent (/private/var/folders/ph/hb9gwd4j1vn7b6hnsbs84d6w0000gn/T/AppTranslocation/45A34DF2-7977-40F4-9E3D-731AC719BB3F/d/Atom.app/Contents/Resources/app/static/<embedded>:11:1253549)
    at KeymapManager.handleKeyboardEvent (/private/var/folders/ph/hb9gwd4j1vn7b6hnsbs84d6w0000gn/T/AppTranslocation/45A34DF2-7977-40F4-9E3D-731AC719BB3F/d/Atom.app/Contents/Resources/app/static/<embedded>:11:1249683)
    at WindowEventHandler.handleDocumentKeyEvent (/private/var/folders/ph/hb9gwd4j1vn7b6hnsbs84d6w0000gn/T/AppTranslocation/45A34DF2-7977-40F4-9E3D-731AC719BB3F/d/Atom.app/Contents/Resources/app/static/<embedded>:11:284496)

Commands

     -3:17.5.0 script:run (input.hidden-input)
     -2:45.7.0 tree-view:add-file (span.name.icon.icon-file-directory)
     -2:42.2.0 core:backspace (input.hidden-input)
     -2:36.6.0 core:confirm (input.hidden-input)
     -2:03.9.0 autocomplete-plus:confirm (input.hidden-input)
     -2:03.9.0 snippets:expand (atom-text-editor.editor.is-focused.autocomplete-active)
  2x -1:58.6.0 core:backspace (input.hidden-input)
     -1:57.5.0 core:select-all (input.hidden-input)
     -1:49.9.0 editor:newline (input.hidden-input)
     -0:11.2.0 cell-navigation:move-cell-up (input#kite.showWelcomeNotificationOnStartup.input-checkbox)

Non-Core Packages

atom-isort 2.6.5 
atom-material-syntax 1.0.8 
atom-material-syntax-dark 1.0.0 
atom-material-ui 2.1.3 
atom-monokai 0.10.9 
atom-python-run 0.9.7 
autocomplete-python 1.16.0 
autocomplete-python-jedi 1.10.3-0 
awesome-material-syntax 0.6.0 
base16-tomorrow-dark-ui 0.1.1 
busy-signal 2.0.1 
cell-navigation 0.1.0 
dark-one-dark-syntax 2.3.0 
data-atom 0.29.1 
data-explorer 0.7.0 
file-icons 2.1.40 
fonts 3.10.0 
Hydrogen 2.14.1 
hydrogen-cell-separator 0.4.1 
hydrogen-launcher 1.2.2 
hydrogen-python 0.0.8 
hyperclick 0.1.5 
intentions 1.1.5 
kite 0.180.0 
language-ini 1.23.0 
linter 2.3.1 
linter-ui-default 1.8.1 
MagicPython 1.1.1 
material-syntax 0.6.1 
minimap 4.29.9 
nucleus-dark-ui 0.12.3 
one-dark-material-syntax 1.0.3 
platformio-ide-terminal 2.10.0 
python-tools 0.6.9 
pythonic-atom 0.2.9 
remote-ftp 2.2.4 
script 3.25.0 
script-runner 2.5.0 
seti-syntax 1.2.0 
tablr 1.8.3 
hoishing commented 4 years ago

The error is caused by triggering cell-navigation without editor panel open. eg. in the 'about' page after Atom starts.

Screenshot 2020-04-17 at 12 22 42 PM

This plug-in suppose to be used with text editor panel. I think you won't get this error while editing code.

Btw, the plug-in triggering condition should be restrict to editor panel only. Improvement needed, thanks for your report ~