search

hokaccha / nodebrew

Node.js version manager
MIT License
1.06k stars 66 forks source link

[feature request] nodebrew link #61

Open watilde opened 7 years ago

watilde commented 7 years ago

I think it would be fun if we could create a symbolic link for Node.js built on your local via nodebrew link like npm link. Since the Release file in node repo does not have node_modules, we need to create a link to the binary you build and create a lib directory to support it in this feature.

draft:

$ cd node
$ make
$ nodebrew link out/Release/node
$ nodebrew use link

tell me your opinion implicitly please 👂

hokaccha commented 7 years ago

It's good idea, I think it would be better if you could name link as follows.

$ nodebrew link foo out/Release/node
$ nodebrew use foo

What do you think?

watilde commented 7 years ago

@hokaccha Absolutely that's better sketch!

Well, I tried to implement this feature immediately, but I'd like to do file splitting before that. Here is the branch: https://github.com/watilde/nodebrew/tree/feature/nodebrew-modules

We can also update to an efficient implementation with something like Class :: Accessor :: Fast, but I'd prefer to implement it with only core modules to keep a process of its installation simple. Then, could I possibly ask you about a particular reason why this package is implemented in a single file if you have? Otherwise, it would be nice if we could incorporate this implementation :)

Thanks!