search

holaplex / wonka

GNU Affero General Public License v3.0
8 stars 1 forks source link

Fix hidden settings candy machines #38

Closed wbarksdale closed 2 years ago

wbarksdale commented 2 years ago

Relates to: https://github.com/holaplex/drops-dashboard/pull/72

This fixes creating candy machines with hidden setting by correctly providing the tokenMint and wallet parameters to the metaplex SDK in candyMachine.ts

This usage can be tested via the run.ts script.

I want to evolve that run.ts into more of a framework for writing quicker more clear tests, but I will do in later PRs

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [4268792](https://dashboard.gitguardian.com/incidents/4268792?occurrence=56663965) | Generic High Entropy Secret | 43b12dc040f0303146916005c6177cf136060721 | src/graphql/candyMachine.ts | [View secret](https://github.com/holaplex/wonka/commit/43b12dc040f0303146916005c6177cf136060721#diff-352e5fa84a6df354b3cbce93d06f0a79336dff53550c2c84ef1b7639e2f1f8f6R208) | | [3590589](https://dashboard.gitguardian.com/incidents/3590589?occurrence=56663966) | Generic High Entropy Secret | 43b12dc040f0303146916005c6177cf136060721 | src/graphql/candyMachine.ts | [View secret](https://github.com/holaplex/wonka/commit/43b12dc040f0303146916005c6177cf136060721#diff-352e5fa84a6df354b3cbce93d06f0a79336dff53550c2c84ef1b7639e2f1f8f6R209) | | [4268792](https://dashboard.gitguardian.com/incidents/4268792?occurrence=57451788) | Generic High Entropy Secret | a66768bd4ef72b1f3b6e413cb39b3fe0cf1445e1 | src/graphql/candyMachine.ts | [View secret](https://github.com/holaplex/wonka/commit/a66768bd4ef72b1f3b6e413cb39b3fe0cf1445e1#diff-352e5fa84a6df354b3cbce93d06f0a79336dff53550c2c84ef1b7639e2f1f8f6L204) | | [3590589](https://dashboard.gitguardian.com/incidents/3590589?occurrence=57451789) | Generic High Entropy Secret | a66768bd4ef72b1f3b6e413cb39b3fe0cf1445e1 | src/graphql/candyMachine.ts | [View secret](https://github.com/holaplex/wonka/commit/a66768bd4ef72b1f3b6e413cb39b3fe0cf1445e1#diff-352e5fa84a6df354b3cbce93d06f0a79336dff53550c2c84ef1b7639e2f1f8f6L205) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!