search

holdenk / spark-testing-base

Base classes to use when writing tests with Spark
Apache License 2.0
1.51k stars 359 forks source link

Adding support for JDK 17 #380

Closed edmondop closed 1 year ago

edmondop commented 1 year ago

This PR adds support for JDK 17 by adding exceptions to new visibility rules introduced by Java 17. The exceptions are taken from the Spark official repository https://github.com/apache/spark/pull/34153

Fixes #358

holdenk commented 1 year ago

This is awesome! Thanks @edmondop :D

holdenk commented 1 year ago

Ah slight problem with the tests. Let me get the tests running on PRs later this week and we can redo.

edmondop commented 1 year ago

Tests were running for me locally but I couldn't trigger the build on the CI. Let me look into those...

Ah slight problem with the tests. Let me get the tests running on PRs later this week and we can redo.

edmondop commented 1 year ago

I see, the problem is only with the distribution not being set in the github workflows. What JDK do you want to use?open jdk?