Goal: limited Github issues title to 65 chars max

holdex / pr-time-tracker

https://autoinvoice-theta.vercel.app

0 stars 3 forks source link

Goal: limited Github issues title to 65 chars max #287

Closed zolotokrylin closed 3 months ago

zolotokrylin commented 4 months ago

Goal: limited Github issues title to 65 chars max

Originally posted by @zolotokrylin in https://github.com/holdex/hr/issues/560#issuecomment-2254872976

zolotokrylin commented 3 months ago

@williamrusdyputra could you please work on this Goal?

zolotokrylin commented 3 months ago

Job story:

when someone creates an issue in GitHub with a title longer then 65 characters
I want our PR tracker app to sent a message in the issue saying "@username please change the title of this issue to make sure the length doesn't exceed 65 characters."
So that this person gets notified and follows our developer guidelines.

williamrusdyputra commented 3 months ago

Alright, I am done with the implementation but having a blocker in last step of testing.

blocker: trigger.dev limitation of new orgs/projects all using v3. I am asking them to enable v2 for me in my project for testing purposes.

I will create a PR linked to this Goal after I have tested the job.

georgeciubotaru commented 3 months ago

@williamrusdyputra Are you using development trigger-dev?

williamrusdyputra commented 3 months ago

@williamrusdyputra Are you using development trigger-dev?

I ran the project following readme and i wanted to define the development endpoint in trigger dev UI, but I cannot create v2 project in the dashboard.

Is there another way of testing?

georgeciubotaru commented 3 months ago

@williamrusdyputra Running the development container should open the already-created project no?

williamrusdyputra commented 3 months ago

I see, yeah, I can access the trigger dev ui from container, my mistake, I thought we didn't self-host the triggerdev.

Thank you!

williamrusdyputra commented 3 months ago

Hello, I want to push to new branch but I don't have write access and forking is disabled in this repo. Can you help me so I can create a PR? @georgeciubotaru , thanks.

zolotokrylin commented 3 months ago

@williamrusdyputra access granted.

georgeciubotaru commented 3 months ago

@williamrusdyputra Left a comment in the last PR, please check

williamrusdyputra commented 3 months ago

@williamrusdyputra Left a comment in the last PR, please check

fixed in new PR

zolotokrylin commented 3 months ago

It didn't work with this one:

https://github.com/holdex/pr-time-tracker/issues/295

georgeciubotaru commented 3 months ago

@zolotokrylin My bad: the new jobs weren't registered

zolotokrylin commented 3 months ago

@georgeciubotaru how did you register them?

georgeciubotaru commented 3 months ago

@zolotokrylin There is a trigger-dev endpoint that checks for job updates every 30-1 hour, and the expected time for applying for new jobs was 9:40. Also, I can trigger refresh manually.

zolotokrylin commented 3 months ago

Do you think it worth to add this in README?

georgeciubotaru commented 3 months ago

@zolotokrylin No, but I will create an Automatic Refresh in Vercel: https://v2docs.trigger.dev/documentation/guides/deployment-automatic

zolotokrylin commented 3 months ago

@georgeciubotaru if this is a custom setting, I suggest we add a note in README

georgeciubotaru commented 3 months ago

@zolotokrylin No need to add anything to Readme