Closed williamrusdyputra closed 1 month ago
@williamrusdyputra is attempting to deploy a commit to the Holdex Accelerator Team on Vercel.
To accomplish this, @williamrusdyputra needs to request access to the Team.
Afterwards, an owner of the Team is required to accept their membership request.
If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.
@williamrusdyputra try this on local trigger-dev with this PR
@williamrusdyputra Also, please update your branch with main
@georgeciubotaru alright, it should be "issue" not "issues", checked out from main also. Thank you!
@georgeciubotaru @williamrusdyputra, The title is vague. What exactly is the "issue"? Please keep it simple – be specific!
@williamrusdyputra Did you check locally?
@williamrusdyputra Did you check locally?
yeah, the graphql query error disappear. Now, it works like before, I just need a real testing example of holdex instead of the webhook example.
@williamrusdyputra You can use this PR, parent issue with trigger-dev locally to check
@zolotokrylin @georgeciubotaru ⚠️⚠️⚠️ You must submit the time spent on this PR. ⚠️⚠️⚠️
The recent updates enhance the management of comments in GitHub issues, specifically by refining the createJob
function and comment retrieval methods. These changes modularize the handling of comments, improving organization, error management, and debugging capabilities. The code structure becomes clearer while preserving the intended functionalities, particularly by shifting focus from pull requests to issues.
Files | Change Summary |
---|---|
src/lib/server/trigger-dev/jobs/issues-creation.ts src/lib/server/trigger-dev/utils.ts |
Improved createJob function to manage comments more effectively, switching comment retrieval from pull requests to issues, and adding a category parameter for enhanced flexibility. |
src/lib/server/trigger-dev/jobs/index.ts |
Modified integration configuration by removing the enabled: false property, which may allow integrations to be enabled by default. |
Objective | Addressed | Explanation |
---|---|---|
Limit GitHub issues title to 65 characters maximum (#287) | ❌ | The objective of limiting the title length is not addressed in the code changes. |
In the garden of code, hops a clever little sprite,
With comments now tidy, everything feels right.
No more pull requests, just issues in sight,
Organizing the chaos, making debugging a delight.
Oh, what a joy, as we code through the night! 🐇✨
Sent edited title with length exceeds 65
Now, the comment is gone after sending edited request with title less than 65.
@williamrusdyputra I want to see these changes in Github meaning, you should change the title of the issue to have more than 65 then to change to a small one, and these changes should be reflected in Github
let me reset one more time
@georgeciubotaru I already tested in parent issue, the history is there, with this screenshot.
Resolves #287
Summary by CodeRabbit
New Features
Bug Fixes