search

holdex / pr-time-tracker

https://autoinvoice-theta.vercel.app
0 stars 3 forks source link

Bug: submission dates are NaN in Bigquery DB #297

Closed georgeciubotaru closed 20 hours ago

georgeciubotaru commented 3 months ago

Some of the records from Bigquery DB contain NaN value for created, updated_at fields of the submission event.

zolotokrylin commented 1 month ago

Does it mean our reports will not be precise if we don't fix that bug?

georgeciubotaru commented 1 month ago

@zolotokrylin It means the sync process will fail, as the dates type should be timestamp not Nan

zolotokrylin commented 1 month ago

@georgeciubotaru,

  1. The sync between what?
  2. What's the workaround and what is a proper solution?
georgeciubotaru commented 1 month ago

@zolotokrylin

  1. The sync between our spreadsheet and the DB
  2. Basically, the NaN dates are inserted as a copy of an existing submissions
    • workaround - remove from DB
    • solution, clarify with that
georgeciubotaru commented 1 day ago

@teodorus-nathaniel Can you please check this issue? basically we get Nan for events (PR_SUBMISSION_CREATED)

teodorus-nathaniel commented 22 hours ago

@georgeciubotaru can you provide more details on this issue? or best thing is, do you know the steps to reproduce it? I just checked the pr-time-tracker.vercel.app/api/events and it seems like from the result it doesn't have any events with NaN updated_at or created_at

From what I checked in code, it just seems like the only probable way this happens is if user somehow updates the submission, but sends created_at or updated_at as undefined.

For this case, I have fixed it in #332 But I can't make sure that this issue is 100% fixed as I don't know the exact reproduction (but imo it should fixes the issue)