search

holdex / pr-time-tracker

https://autoinvoice-theta.vercel.app
0 stars 3 forks source link

fix: send bug report event to google bigquery #322

Closed teodorus-nathaniel closed 1 week ago

teodorus-nathaniel commented 1 week ago

resolves #321

Note: @holdex/autoinvoicing needs to be republished, because subscription action filter, to subscribe to issue_comment event with edited and deleted action

Summary by CodeRabbit

Release Notes

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autoinvoice ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 3:54pm
coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on enhancing event handling for GitHub issue comments and pull requests. Key updates include a version bump in the package.json, modifications to event specifications for issue comments, the addition of new functions for managing bug reports, and improvements in the handling of check run events. The changes also streamline the code by removing unused types and functions, thereby clarifying the control flow related to bug report processing.

Changes

File Path Change Summary
integrations/autoinvoicing/package.json Version updated from 0.0.10 to 0.0.11.
integrations/autoinvoicing/src/index.ts Updated onIssueComment event specification filter to include ['created', 'edited', 'deleted'].
src/lib/@types/types.ts Added new enum value BUG_INTRODUCED to EventType.
src/lib/server/trigger-dev/fix-pr.ts Introduced functions for managing bug reports linked to pull requests, including runPrFixCheckRun.
src/lib/server/trigger-dev/jobs/check-run.ts Enhanced handling of check run events to differentiate between submissions and bug reports.
src/lib/server/trigger-dev/jobs/issues-comment.ts Expanded createJob function to handle edited and deleted actions for issue comments.
src/lib/server/trigger-dev/jobs/pull-requests-review.ts Updated import for runPrFixCheckRun and adjusted its invocation timing.
src/lib/server/trigger-dev/jobs/pull-requests.ts Updated import for runPrFixCheckRun and added logic for handling synchronize action.
src/lib/server/trigger-dev/utils.ts Removed types and functions related to pull request event handling, updated parameter types.

Assessment against linked issues

Objective Addressed Explanation
Ensure bug events are captured in the developer's spreadsheet (#321) ✅

Possibly related PRs

Suggested reviewers

[!WARNING]

Rate limit exceeded

@teodorus-nathaniel has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between 6e102e91c25e24a4ab5f543f9b83747b8d0cab7c and 16a59a7e19cc4f4cf7bc46b73996e1033d486ad2.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
teodorus-nathaniel commented 1 week ago

@pr-time-tracker bug commit 28610aa && bug author @teodorus-nathaniel

teodorus-nathaniel commented 1 week ago

@georgeciubotaru

We need to have a check that will inform the PR creator to submit bug info, that check run block the PR merging

For this, yes the check is already there and its already updated to neutral if its not relevant anymore

the bug info event can be emitted when is the most suitable moment

For this, its emitted after the pr is merged, as we discussed before in #321.