holepunchto / hypercore

Hypercore is a secure, distributed append-only log.
https://docs.holepunch.to
MIT License
2.57k stars 183 forks source link

Unslab manifest #545

Closed HDegroote closed 2 months ago

HDegroote commented 2 months ago

Current behaviour is that it retains buffers through signer.publicKey and signer.namespace (sometimes buffers of multiple Mb if they come from UDX).

This fixes the leak on the code paths I can reproduce.

Warning: I'm not sure it's safe to call Verifier.createManifest on passed-in manifests (for example, it will throw for non-blake2b hashes)