search

holepunchto / hyperdht

The DHT powering Hyperswarm
https://docs.holepunch.to
MIT License
323 stars 46 forks source link

Destroy open streams on `dht.destroy()` #111

Closed kasperisager closed 1 year ago

kasperisager commented 1 year ago

@mafintosh This is ready for review.

kasperisager commented 1 year ago

@mafintosh This is ready for another look.

mafintosh commented 1 year ago

Looks good. Test failure is due to a test not error handling i think (cause we are tearing down the streams aggresively now on test end)

LuKks commented 1 year ago

Great, it also fixes https://github.com/hyperswarm/dht/issues/86 Only difference with v5 and v6 is that now it's giving ECONNRESET but that is correct as the socket was open

mafintosh commented 1 year ago

6.3.5