add connectionKeepAlive opt - Githubissues

holepunchto / hyperdht

The DHT powering Hyperswarm

https://docs.holepunch.to

MIT License

323 stars 46 forks source link

add connectionKeepAlive opt #177

Closed HDegroote closed 6 months ago

HDegroote commented 6 months ago

TODO's before marking ready: (all done)

Should the keepAlives for the relays use the passed-in value if non-0, or remain fixed at 5s? (https://github.com/holepunchto/hyperdht/blob/79eea93b25b975715a769d2f3440994224fab7d3/lib/server.js#L613 and https://github.com/holepunchto/hyperdht/blob/79eea93b25b975715a769d2f3440994224fab7d3/lib/connect.js#L693) can be considered later
~~Cut a hyperswarm-secret-stream release with https://github.com/holepunchto/hyperswarm-secret-stream/pull/30 so the tests don't rely on a private prop~~ Done

mafintosh commented 6 months ago

6.14.0