search

holepunchto / hyperdht

The DHT powering Hyperswarm
https://docs.holepunch.to
MIT License
323 stars 46 forks source link

Optional Non-encrypted streams #46

Open lanmower opened 3 years ago

lanmower commented 3 years ago

Some users might want to pipe encrypted streams over createServer, can we have an option to disable encryption to avoid double encrypting?

mafintosh commented 3 years ago

This is a bit more complicated in practice as streams are paired based on encryption headers. I'm open to it, but only if it requires little internal overhead and prop needs someone from the community to spearhead.

lanmower commented 3 years ago

would it be possible to do it based on dht/rpc by exposing it? I recall that having unencrypted streams

mafintosh commented 3 years ago

dht-rpc does not have any streams what so ever. as said, its possible with work

lanmower commented 3 years ago

I understand now thanks for explaining, the encryption keys being what identifies a stream for that layer of the conneciton and dht-rpc dealing purely with dht

On Thu, Oct 7, 2021 at 10:04 AM Mathias Buus @.***> wrote:

dht-rpc does not have any streams what so ever. as said, its possible with work

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hyperswarm/dht/issues/46#issuecomment-937551790, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFAPIZEQX7FPOBQVPEF5QDUFVH77ANCNFSM475QCXYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

As an additional note, I had to use events instead of pipe, you can not kill the whole connection on an end anywhere on the chain, it has to be done transversely instead.