Preventing unexpected close error that occurs with newer version of hypercore

holepunchto / hyperdrive

Hyperdrive is a secure, real time distributed file system

Apache License 2.0

1.86k stars 134 forks source link

Preventing unexpected close error that occurs with newer version of hypercore #231

Closed martinheidegger closed 5 years ago

martinheidegger commented 5 years ago

Hypercore introduced a new error to callbacks when closing. This should have probably been a breaking change, as it triggers a new error on close in hyperdrive.

This PR adds a test for the new error case 33e0acab6ccee88c5ee77a0ef24f30c0ea94c400 and fixes it by using a flag if the hypercore is closed 79d10ad777a2aeade0af4e7a22b7d3fc8017e78f.

mafintosh commented 5 years ago

Thanks! 9.14.1