Closed 4c656554 closed 2 years ago
@4c656554 thanks for this, and sorry for being slow to review. Mind adding a test case for this, especially one to make sure that the callback is still handled correctly?
@andrewosh Thanks, correct me if I'm wrong, but I don't think it's possible (or it is possible then it'd be pretty strange) to call download
with path undefined and with a callback.
Perhaps a better fix would be to change the function def:
download (path="", opts, cb) { ...
If you agree, I'll create a new commit with that?
Also, I've suggested a test case based on the directory download case, see #312
Issue #309