search

holepunchto / hyperdrive

Hyperdrive is a secure, real time distributed file system
Apache License 2.0
1.85k stars 136 forks source link

Fix blobs session leak on batching #337

Closed HDegroote closed 1 year ago

HDegroote commented 1 year ago

Currently a new blobs core session is created whenever a new batch is created, but they are never closed. This PR always closes the blobs core of a batch.

LuKks commented 1 year ago

Unrelated to the PR but we should move the order of the internal methods so potential leaks are clearer, for example, currently _close is first, later way below there is _open, etc we should re-arrange the order of methods. It's like when organizing the READMEs, we should mimic the same logical order