Swallow all empty messages

holepunchto / hyperswarm-secret-stream

Secret stream backed by Noise and libsodium's secretstream

Apache License 2.0

33 stars 14 forks source link

Swallow all empty messages #29

Closed HDegroote closed 3 months ago

HDegroote commented 3 months ago

Current behaviour is to only swallow empty messages if your own keepAlive is set. This means that if the other side has set keepAlive while you haven't, those empty messages will be passed on to the piped stream.

This PR makes it so empty messages are always swallowed.

Note: if anything upstream relies on empty messages for anything other than keepAlive, it will break.

mafintosh commented 3 months ago

closing for now per our discussion