search

holepunchto / hyperswarm

A distributed networking stack for connecting peers.
https://docs.holepunch.to
MIT License
1.04k stars 84 forks source link

N-API warning #10

Closed staltz closed 4 years ago

staltz commented 5 years ago

I ran example-s.js in multiserver-dht on branch hyperswarm, with node v8.11.1, and got the error:

(node:11413) Warning: N-API is an experimental feature and could change at any time.
node: symbol lookup error: ./multiserver-dht/node_modules/@hyperswarm/network/node_modules/utp-native/prebuilds/linux-x64/node-napi.node: undefined symbol: napi_fatal_exception

If node v10 is a requirement, then that could be added to engines in package.json.

mafintosh commented 5 years ago

Is that latest 8? It’ll work in anything above 6 but some 8 versions print the warning

mafintosh commented 5 years ago

(It might be that all 8 versions do)

staltz commented 5 years ago

Interesting, it works on v8.12.0. ("Works" means that this error does not occur but I see error #11 instead) Would still be good to add the compatible engines in package.json

mafintosh commented 5 years ago

It's compatible with any version of 8 it just prints the error in earlier versions but yea we should specify that :)