search

holepunchto / hyperswarm

A distributed networking stack for connecting peers.
https://docs.holepunch.to
MIT License
1.03k stars 84 forks source link

Fix connection reset by peer on test #133

Closed LuKks closed 1 year ago

LuKks commented 1 year ago

Re-running tests to confirm

LuKks commented 1 year ago

One issue is that after doing conn.end() swarms gets destroyed so it throws the error, no problem as we can noop it

Preferably we should not noop all errors, i.e. we could wait for socket 'close' event, etc but then CI slowness makes it to do a second reconnect lol, so just noop'ing for now

LuKks commented 1 year ago

That CI error on Windows is very different and unrelated to this PR

image

Edit: CI link https://github.com/holepunchto/hyperswarm/actions/runs/4385286067/jobs/7677811089

LuKks commented 1 year ago

@mafintosh Ready!