Add a destroy function - Githubissues

AcidLeroy commented 5 years ago

Currently there is no way to destroy the network directly, this merge request attempts to solve that issue.
There are accompanying tests, but they have an issue where they don't exit if this test fails.
It would be nice if there was a way to exit the test if the process handles are above a certain threshold, although preliminary tests show that there wasn't really a correlation between the number of handles and requests open and whether or not the test would exit.

Signed-off-by: Cody W. Eilar Cody.Eilar@Gmail.com

bencevans commented 5 years ago

This doesn't appear to destroy if announce is set to true on any network joins.

AcidLeroy commented 5 years ago

@bencevans That's unfortunate. I guess I didn't test with that setting. When I have some time I'll take a look at getting the test to pass with both announce: true and announce: false

mafintosh commented 5 years ago

Fixed in latest

holepunchto / hyperswarm

Add a destroy function #16