search

holepunchto / hyperswarm

A distributed networking stack for connecting peers.
https://docs.holepunch.to
MIT License
1.04k stars 84 forks source link

Replace `Buffer` with `b4a` #98

Closed kasperisager closed 2 years ago

Nuhvi commented 2 years ago

turbo-hash-map is not "unbuffered", so it throws t.key.equals is not a function

kasperisager commented 2 years ago

Ah, good catch! ~I'll open~ I've opened a PR: https://github.com/mafintosh/turbo-hash-map/pull/3

mafintosh commented 2 years ago

@kasperisager can we split this into two PRs? One for turbo and one for b4a?

kasperisager commented 2 years ago

That would cause them to conflict, but I can absolutely split them if you'd prefer to land one or the other first?

mafintosh commented 2 years ago

Ya b4a first, because I'm unsure if we'll land turbo anytime soon. Benchmarks showed some weird behaivour that we have to investigate, so don't want that to hold up b4a

kasperisager commented 2 years ago

@mafintosh All set!

kasperisager commented 2 years ago

The tests are stalling on Windows for some reason 🤔

mafintosh commented 2 years ago

Stall is another test regression, we've discovered. Debugging that separately.