Add Support for disable Hardware Acceleration

holepunchto / pear

combined Peer-to-Peer (P2P) Runtime, Development & Deployment tool

https://docs.pears.com/

Apache License 2.0

91 stars 9 forks source link

Add Support for disable Hardware Acceleration #37

Closed dabuchera closed 2 days ago

dabuchera commented 6 months ago

Electron has some known issues related to VSync (Vertical Synchronization) parameters retrieval failures, especially for newer Ubuntu distributions (see https://github.com/electron/electron/issues/40727)

An easy solution would be to add something like the below to electron-main.js - function configureElectron ()

if(process.env.ELECTRON_DISABLE_HARDWARE_ACCELERATION === 'true'){
 electron.disableHardwareAcceleration();
}

What's your take on that?

heyitsvi commented 5 months ago

This is the same case for Debian 12. Can't execute any examples because of this issue @mafintosh Ref : https://github.com/electron/electron/issues/32760

davidmarkclements commented 2 months ago

we'll add a flag to pear run

davidmarkclements commented 2 days ago

we've not done this because it just feels like a patch to a problem that users shouldn't have to deal with, as of v0.4444.pqbzjhqyonxprx8hghxexnmctw75mr91ewqw5dxe1zmntfyaddqy electron is upgraded to v31.2.0 which seems to be more stable around this esp on linux - so this is a wontfix for now but we'll revisit it if we really have to.