search

holepunchto / pear

combined Peer-to-Peer (P2P) Runtime, Development & Deployment tool
https://pears.com/
Apache License 2.0
86 stars 9 forks source link

(WIP) Treat updateNotify async #67

Closed HDegroote closed 4 months ago

HDegroote commented 4 months ago

The updateNotify logic seems to assume it's a sync function, but it's async, so the logic is bugged.

This is a WIP still because I wanted to sanity check first if the overall approach is still sound. The 2 TODO's indicate where it would still require changing

HDegroote commented 4 months ago

The proper fix is to make updateNotify sync, here: https://github.com/holepunchto/pear/pull/68