search

holgerbrandl / kalasim

Discrete Event Simulator
https://www.kalasim.org/
MIT License
68 stars 10 forks source link

Dark mode documentation #63

Closed aSemy closed 1 year ago

aSemy commented 1 year ago

Please could docs be updated to include a dark-mode toggle? :)

This should be pretty easy with mkdocs, see these PRs for inspiration:

I'm willing to make a PR, if you'd like

aSemy commented 1 year ago

P.S. it would be nice to add the documentation URL on the GitHub About section

image
holgerbrandl commented 1 year ago

Oh "these" dark mode people. :-) Thanks for the suggestion. The links contrast when using dark mode now, lack a bit of contrast in my taste, but I guess it's fine for now.

I've adjusted the link as well.

aSemy commented 1 year ago

Wonderful, thank you on behalf of the dark mode people! :)

Yes, the link contrast is very low... It looks like it might be this issue https://github.com/squidfunk/mkdocs-material/issues/4600? Although it does look like kalasim is using the latest versions of Mkdocs and Mkdocs Material... but I'm not very familiar with Mkdocs or Python.

holgerbrandl commented 1 year ago

Not sure how to indicate a more recent version in https://github.com/holgerbrandl/kalasim/blob/master/.github/workflows/manual.yml The mkdocs version comes along somehow via the github action system.