search

holgerbrandl / krangl

krangl is a {K}otlin DSL for data w{rangl}ing
MIT License
560 stars 50 forks source link

Please register SimpleDataFrame for polymorphic serialization in the future if possible. #131

Open arybach opened 3 years ago

arybach commented 3 years ago

Exception in thread "main" kotlinx.serialization.SerializationException: Class 'SimpleDataFrame' is not registered for polymorphic serialization in the scope of 'DataFrame'. Mark the base class as 'sealed' or register the serializer explicitly.

Thank you very much.

holgerbrandl commented 3 years ago

What about GroupedDataFrame? Wouldn't we then rather need to mark the upstream interface DataFrame itself?

I've tried but did not come up with a good argument against sealed. So this should work.

arybach commented 3 years ago

Great! Thx vm.

holgerbrandl commented 3 years ago

Let's keep it open until it is actually implemented.