CsvReaderTests refactoring

holgerbrandl / krangl

krangl is a {K}otlin DSL for data w{rangl}ing

MIT License

560 stars 50 forks source link

CsvReaderTests refactoring #140

Closed sorokod closed 2 years ago

sorokod commented 2 years ago

Refactored CsvReaderTests and increased coverage
Replaced test HTTP calls to GitHub with calls to a local HTTP server
Fixed minor bug: TableIO.isURL should be case insensitive

holgerbrandl commented 2 years ago

What was wrong with the calls to gthub to query test resources?

sorokod commented 2 years ago

What was wrong with the calls to gthub to query test resources?

Well, to me it looks out of place in a unit test. Especially when this is purely to exercise the transport rather then an actual remote functionality.

Otherwise - the test fails when I am offline or when GitHub has an outage :-)

holgerbrandl commented 2 years ago

I understand. Thanks for the fix.