search

holgerbrandl / krangl

krangl is a {K}otlin DSL for data w{rangl}ing
MIT License
560 stars 50 forks source link

Tests internationalization #144

Closed Kopilov closed 2 years ago

Kopilov commented 2 years ago

Hello! I like this library and want to use and improve it. At first, I have made tests working on my workstation. My PC has locale ru_RU.UTF-8 by default, but tests have some cases on human-readable output that currently work only with en_US.UTF-8(may be, this is your) or C.UTF-8 (default in GitHub Actions CI)

Kopilov commented 2 years ago

Also some dependencies were upgraded and library version was bumped from 0.17.2 to 0.17.4-SNAPSHOT. 0.17.3 release is currently out of master branch, should we merge it?

holgerbrandl commented 2 years ago

Thanks for the PR. I clearly see the need that it should work with different locals, but shouldn't we stick to one local in the tests to keep it simple?

Kopilov commented 2 years ago

OK, let it be kept simple now. In future, may be, it would be better to separate all human-readable tests and run them with different locales in CI.