holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.
http://pyedflib.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
214 stars 121 forks source link

fix badges, add pypi badge #140

Closed sappelhoff closed 3 years ago

sappelhoff commented 3 years ago
  1. Adds "alt" text to each badge that shows up when the SVG cannot be loaded
  2. removes one of the two conda badges, which was simply pointing to the conda-forge repository (all packages therein): https://conda.anaconda.org/conda-forge
  3. replaces the pyedflib-specific conda-forge badge with one that explicitly says that this package is on conda-forge
  4. Adds a PyPI badge next to the conda badge

Before:

image

After:

image

skjerns commented 3 years ago

Great add! Thanks a lot for the contribution.

Do you know why the coverage badge doesn't work?

sappelhoff commented 3 years ago

Do you know why the coverage badge doesn't work?

I took a brief look at the different CIs you have running, but I wasn't sure how welcome meddling would be so I stopped again :-)

I can take another look if you want.

sappelhoff commented 3 years ago

Also, the code quality badge seems broken:

image

skjerns commented 3 years ago

Ah okay thanks again, and also for looking into the coverage badge.

I don't think I can fix the Travis as I am not the owner of the repo, I guess @holgern would need to do that. But I'd say that's low prio

sappelhoff commented 3 years ago

But I'd say that's low prio

you mean because running CircleCI and appveyor is sufficient? :thinking:

Because the whole Travis CI is not running, it's not just the coverage reports that are missing.

skjerns commented 3 years ago

Ah that could be! Sorry I'm on mobile right now, can't easily check it. I'll look into it next week :)

skjerns commented 3 years ago

looks good, let's try to fix the coverage in #141

thanks for the contribution!