try to fix codecov upload -> TRAVIS authorization problem

holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.

http://pyedflib.readthedocs.org/

BSD 3-Clause "New" or "Revised" License

214 stars 121 forks source link

try to fix codecov upload -> TRAVIS authorization problem #141

Closed sappelhoff closed 3 years ago

sappelhoff commented 3 years ago

as discussed in #140

not sure if it works, but worth a try.

sappelhoff commented 3 years ago

@skjerns the problem is that Travis is not building at all: https://travis-ci.com/github/holgern/pyedflib/requests

Some authorization problem:

sappelhoff commented 3 years ago

relevant: https://stackoverflow.com/a/41327657/5201771

skjerns commented 3 years ago

@holgern can you check the authorization on travis/coverage?

however, it's a bit strange as the regular builds work fine

sappelhoff commented 3 years ago

however, it's a bit strange as the regular builds work fine

but the last Travis CI builds are more than a month past - despite several merges (other than PRs) in between :thinking:

Or are both of us looking at different data? --> https://travis-ci.com/github/holgern/pyedflib/builds

holgern commented 3 years ago

@skjerns I checked the authorization and they look fine. Should we change the coverage tool?, maybe there is a better one or the coverage should not be uploaded from travis.

skjerns commented 3 years ago

yes, that seems like a good idea. currently there are three CI tools active anyway (travis, circle, AppVeyor ?), I guess one or two should be sufficient. However, they should all be triggered for PRs and branches and not only on master. Currently only appveyor seems to run in PRs?

I guess the coverage should be able to upload from either of those. which one do you prefer to work with? I think CircleCI is more popular and might be easier to get support

skjerns commented 3 years ago

Alternatively we could just use github actions for running tests?

best integration and no authorization problems
less verbose interface and might be a bit more cumbersome if stuff fails

example from one of my other repos, tests running on Mac/Linux/Windows https://github.com/Unisens/pyunisens/blob/master/.github/workflows/Tests.yml

skjerns commented 3 years ago

I created a workflow for codecov and it works now.

However I'm not sure if the Cython code was validated before, and if that's now missing?

I also removed all traces of travis. Additionally, as the codacy code quality badge wasn't working I removed it. If you want to re-add it, feel free to do so, I think you need to re-authorize the app @holgern .

@holgern let me know if the Cython code was tested against before within coverage and if that should be enabled again. Also if you think we should switch entirely to github actions and not use third-party-providers.

sappelhoff commented 3 years ago

nice, thanks for fixing this @skjerns