search

holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.
http://pyedflib.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
209 stars 121 forks source link

Fix writing of annotations in very long records #176

Closed skjerns closed 2 years ago

skjerns commented 2 years ago

Annotations starting time were indicated as Python int, which turned out to be interpreted by numpy as int32, limiting the annotations to a bit over 50 hours. Now it get's correctly converted to to int64 -> long long which should be sufficiently long in terms of annotation seconds.

codecov[bot] commented 2 years ago

Codecov Report

Merging #176 (2d4585b) into master (a616138) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files           4        4           
  Lines         828      828           
  Branches      180      180           
=======================================
  Hits          647      647           
  Misses        144      144           
  Partials       37       37
Flag Coverage Δ
unittests 78.14% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyedflib/edfwriter.py 87.02% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a616138...2d4585b. Read the comment docs.