Remove commented code and merged from develop

holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.

http://pyedflib.readthedocs.org/

BSD 3-Clause "New" or "Revised" License

209 stars 121 forks source link

Closed gcathelain closed 1 year ago

gcathelain commented 1 year ago

@skjerns I don't have permission to review your PR #159 on @holgern repository, so I made a fork of issue148_samplerate2 with very few changes :

Merge develop branch to your issue148_samplerate2 branch to have the most recent version of pyedflib
Remove commented code

I have nothing to say concerning your changes, they seem perfectly OK.

Tests run OK on my side and my use case works fine with your code, if I could accept your PR I would do it right now !

skjerns commented 1 year ago

Thanks! The changes seem reasonable. I'll merge this one, have one last go through my changes in the other PR and then merge it.