search

holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.
http://pyedflib.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
223 stars 124 forks source link

Incompatible with numpy>=1.25 #218

Closed wenh06 closed 1 year ago

wenh06 commented 1 year ago

Numpy released version 1.25 a few days ago, and Tester is removed from this version, ref. NumPy 1.25.0 Release Notes.

File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pyedflib/init.py", line 19, in from numpy.testing import Tester ImportError: cannot import name 'Tester' from 'numpy.testing'

Perhaps, the requirements should be updated to restrict to numpy < 1.25 or remove the usage of Tester in the __init__.py file.

wenh06 commented 1 year ago

There's already PR #216

skjerns commented 1 year ago

should be fixed in #216

wenh06 commented 1 year ago

Uploading to PyPI failed, since the minor version number is not changed, which should be incremented by one, as in #227

skjerns commented 1 year ago

ah, forgot that, thnaks!