holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.
http://pyedflib.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
214 stars 121 forks source link

setup.py → pyproject.toml #225

Closed DimitriPapadopoulos closed 1 year ago

DimitriPapadopoulos commented 1 year ago

Move to pyproject.toml and make setup.py a thin wrapper

Configuring setuptools using pyproject.toml files

skjerns commented 1 year ago

This would probably be a bit hacky due to the Cython compilation and Numpy Extension during build. See e.g. https://stackoverflow.com/questions/73800736/pyproject-toml-and-cython-extension-module

Unless there is an advantage or setup.py get's deprecated I'd prefer to leave it as is. Currently it would require us to have one additionaly file for the Cython building process + setup.py + project.toml, so it's a bit cleaner using only setup.py+project.toml

DimitriPapadopoulos commented 1 year ago

Indeed setup.py is slowly getting deprecated. See for example https://github.com/adrienverge/yamllint/issues/509#issuecomment-1493351047.

I agree it will be tricky. We should probably look into NumPy for ideas.