search

holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.
http://pyedflib.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
209 stars 121 forks source link

Add macOS ARM64 wheels #244

Closed cbrnr closed 9 months ago

cbrnr commented 9 months ago

I noticed that macOS ARM64 wheels are missing, so hopefully this PR will add them. Is there a way to test if this works on cibuildwheel?

skjerns commented 9 months ago

yes, but only on branches from the same repo. I added them here #245 , it seems to work

cbrnr commented 9 months ago

Are the wheels available for download so that I can test installing them locally? I don't see the output...

skjerns commented 9 months ago

Not yet, need to make a new release for that, will do later

cbrnr commented 9 months ago

But I meant how do you know that the wheels are building OK when they are not being built? Or are they, and there are just no artifacts to download?

skjerns commented 9 months ago

they were build, but not uploaded due to no new release, the current build should be done any minute and then upload them

cbrnr commented 9 months ago

Where do you see that they were successfully built?

skjerns commented 9 months ago

Where do you see that they were successfully built?

https://github.com/holgern/pyedflib/actions/runs/6459073038/job/17534120890

cbrnr commented 9 months ago

Thanks! But that happens only when you create a new tag, right? Would it not be useful to build all wheels for every PR? I mean, if you want to avoid a situation where wheels fail, then you would have to create another tag just to fix the wheels.

skjerns commented 9 months ago

The wheel building can also be started by workflow dispatch, but then the wheels wont upload to pypi, that only works if the version is incremented :)

I tested the wheels build on a branch and once that was confirmed, I created the tag

cbrnr commented 9 months ago

Ah, got it!