holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.
http://pyedflib.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
223 stars 124 forks source link

Support Cython 3 #248

Closed musicinmybrain closed 1 year ago

musicinmybrain commented 1 year ago

Fix a relative cimport and revert the commit that pinned cython<3.0.

skjerns commented 1 year ago

I assume #233 and #234 has been fixed?

musicinmybrain commented 1 year ago

I assume #233 and #234 has been fixed?

Yes, I found that everything was fine (it compiled and the tests passed) after I fixed the cimport:

      cimport c_edf
              ^
      ------------------------------------------------------------

      pyedflib/_extensions/_pyedflib.pyx:24:8: 'c_edf.pxd' not found
skjerns commented 1 year ago

Strange, I could have sworn that I tried that.

Thanks! That fixes it :)