holgern / pyedflib

pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib.
http://pyedflib.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
219 stars 124 forks source link

Add Type Hints for Improved Static Analysis #263

Open joseph-pq opened 1 week ago

joseph-pq commented 1 week ago

Hi! I noticed that the codebase currently lacks type hints. I'm wondering if this was an intentional decision or if it's a TODO item for the project.

Type hints would bring several benefits, such as:

Would you be open to introducing type hints throughout the project? If so, I'd be happy to help by submitting a pull request or working with the team to add them.

Looking forward to your thoughts!

skjerns commented 1 week ago

Good idea! There's no reason not to do that :)

If you want to go ahead, feel free to make a PR!