holgerteichgraeber / TimeSeriesClustering.jl

Julia implementation of unsupervised learning methods for time series datasets. It provides functionality for clustering and aggregating, detecting motifs, and quantifying similarity between time series datasets.

MIT License

82 stars 23 forks source link

test cases without CapacityExpansion.jl dependency #85

Closed holgerteichgraeber closed 5 years ago

holgerteichgraeber commented 5 years ago

Let's write the test cases such that it is not dependent on capacity expansion, because that dependency makes tests fail whenever we update ClustForOpt with breaking changes.

YoungFaithful commented 5 years ago

If we don't include the CEP tests, we might oversee breaking changes without intending them.

holgerteichgraeber commented 5 years ago

I agree that it should be part of the workflow. If CEP is part of the tests though, the tests will always fail if there is a breaking change, because CEP hasn't been updated for these changes yet.

If it is tested upstream in CEP itself, we will find the breaking changes through that as well. The test cases in clustForOpt should be complete enough (which they are not yet) to cover the things that are relevant to CEP without using the package itself.

YoungFaithful commented 5 years ago

Okay. Sounds good.

holgerteichgraeber commented 5 years ago

84 taken out CapacityExpansion test cases and replaced by a simple case if load_data and run_clust works. Will need to write more detailed test cases in the future that tests a broad spectrum of the functionality though.