search

holgi / fastapi-permissions

row level security for FastAPI framework
Other
475 stars 47 forks source link

__acl__ was never awaited #5

Open Tears opened 3 years ago

Tears commented 3 years ago

Hi,

First of all, thanks for making this library. I'm on my first FastAPI project right now and we're really liking the library so far.

However, we do run into a little problem when using dynamically generated ACL's. Our app is connected via Tortoise ORM to a PostgreSQL-database, from which we are generating the ACL's in the models. We are required to approach the database async, so we need to make the ACL-function in the model async as well. Like this:

async def __acl__(self) -> List:

    acl = []

    # Do stuff with the database here, and append them as rules in the ACL
    # Example:
    async for attendee in self.parent_activity.get_attendees():
        acl.append((Allow, f"user:{attendee.user.id}", "view"))

    return acl

However, when checking the object this ACL is attached to via the Permission-function, we are greeted with the following error:

RuntimeWarning: coroutine 'Activity.__acl__' was never awaited

(Activity is the model name)

Could you maybe implement an await for the ACL's? Like I said, this is my first project with FastAPI so maybe I'm using it all wrong, but we are stuck with this now. Thanks in advance!

holgi commented 3 years ago

Hi,

probably you did nothing wrong. I never used an async db access for this - so it's seems to be a case I haven't considered.

I have an idea on how to solve this, I "just" need some time to get to this and I'd like to ask you for some patience.

Tears commented 3 years ago

Hi, thanks for your reply. Could you describe your idea on how to solve this? Maybe I could take a look then and submit a PR.

jsenecal commented 2 years ago

Is there any progress that was made @holgi ? I too, am hitting this bug with motor/beanie

Gadgetguycj commented 1 year ago

Running into the same issue as well, will post any protentional solutions I find