search

holic / cms

Dynamic CMS with React + Firebase
9 stars 8 forks source link

Firebase API key is public #1

Closed flexwie closed 6 years ago

flexwie commented 7 years ago

You should maybe think about outsourcing your Firebase API key to a private config file which is not commited to the public repository

holic commented 7 years ago

Definitely will. Thanks for the reminder :)

On 1/12/2016, at 4:47 PM, Felix Wieland notifications@github.com wrote:

You should maybe think about outsourcing your Firebase API key to a private config file which is not commited to the public repository

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

flexwie commented 7 years ago

Or you set it as an environement variable

holic commented 6 years ago

Done in https://github.com/holic/cms/commit/b160037ea7e92e1d1fefb43316e75924e0f2021f