Allow scheme/protocol to be passed to script

holidaycheck / react-google-tag-manager

This repository contains a react based implementation for Google's Tag Manager snippet.

MIT License

192 stars 31 forks source link

Allow scheme/protocol to be passed to script #55

Closed richardstevens closed 7 years ago

richardstevens commented 7 years ago

Googles GTM now seems to redirect any http request to https, this now causes an extra redirect which seems wasteful. This proposal is to allow someone to pass in the scheme they desire so someone can always call https if they want. The alternative would be to always use https hardcoded in the scripts, however i'm not sure if people want that and would prefer to keep it as it currently sits.

FQ400 commented 7 years ago

Sorry @richardstevens @HeeL for the trouble I had to revert the merged changes, because of missing tests.

richardstevens commented 7 years ago

No problem @FQ400, ill update and add tests, documentation