search

holidaycheck / react-google-tag-manager

This repository contains a react based implementation for Google's Tag Manager snippet.
MIT License
192 stars 31 forks source link

allow for additional params to be passed for staging environments #61

Closed iamkevingreen closed 7 years ago

iamkevingreen commented 7 years ago

You can pass additional params to the gtm code so that you can create testing environments and not fire in the production environment of gtm.

I added a prop that can handle that and test that checks it's contents, open to implementing it differently but think this would be valuable, it also allows you to test gtm without putting the container in live mode.

FQ400 commented 7 years ago

@iamkevingreen The package wasn't updated to node8 and npm5 yet when the package-lock.json file was introduced. The file shouldn't be added. I guess it would produce more issues then benefits.

4min commented 7 years ago

Guys, is there any chance this can be merged soon? Configuring analytics right now and this is exactly the missing feature we need.

phildionne commented 7 years ago

Same here, would be great to see this merged :)

FQ400 commented 7 years ago

ping @gilligan @singles @0xPIT