search

holidaycheck / react-google-tag-manager

This repository contains a react based implementation for Google's Tag Manager snippet.
MIT License
192 stars 31 forks source link

Example fixed to use https by default #77

Closed pruser closed 6 years ago

HeeL commented 6 years ago

Can you please also add scheme prop in prop table in this README?

pruser commented 6 years ago

Sure, I can pass it as a prop to the example component, but isn't it redundant? It's quite unlikely that somebody would use different schemes to load the script in one project. What's your opinion?

HeeL commented 6 years ago

Thank you, merging this...

HeeL commented 6 years ago

@pruser we don't use this prop in our case, I can imagine that someone prefer to use https even though the website is on http for some reason