holidaycheck / react-google-tag-manager

This repository contains a react based implementation for Google's Tag Manager snippet.
MIT License
192 stars 31 forks source link

Preview variables string or boolean? #81

Open rafaeldwan opened 6 years ago

rafaeldwan commented 6 years ago

In the example code if previewVariables is not present false is supplied. However, the PropType given is string. Shouldn't the default value instead be an empty string, '', not false?

I ask because this is generating a warning,

Failed prop type: Invalid prop `previewVariables` of type `boolean` supplied to `GoogleTagManager`, expected `string`.