search

holidayextras / barometer

Framework agnostic browser performance metrics
MIT License
5 stars 4 forks source link

v2.0.0 - Prometheus metrics #42

Closed theninj4 closed 7 years ago

theninj4 commented 7 years ago

This PR updates barometer to emit prometheus style metrics. I had to bump some dependency versions to get the selenium tests running, and upgrades eslint whilst I was there.

The main change here is the way in which hosts and paths are transmitted - they used to be a best-efforts stab at a dot-separated graphite metric. They're now a nice clean prometheus metric with easy-to-understand labels.

Something's not right about the IE7/IE8 builds on saucelabs anymore, it's not a test or code issue but rather a test suite integration issue. We don't expect our projects to run on those browsers, so I'm not too worried about them missing from the test suite.

theninj4 commented 7 years ago

I think the best way forward here is to get these features merged as-is, and I'll loop back around on the test suite in a second PR to try and understand where we stand with the older browsers and get the builds green.