search

holidayextras / jsonapi-server

A config driven NodeJS framework implementing json:api and GraphQL
MIT License
488 stars 115 forks source link

additional parameters are not concated #389

Open championswimmer opened 6 years ago

championswimmer commented 6 years ago

Check here https://github.com/holidayextras/jsonapi-server/blob/master/lib/swagger/paths.js#L290

wrong

pathDefinition.parameters.concat(additionalParams)

should be 

pathDefinition.parameters = pathDefinition.parameters.concat(additionalParams)
pmcnr-hx commented 6 years ago

Indeed! concat doesn't mutate it's argument. Will fix. Thanks for reporting!